Add more training models and RLHF algorithms #6368
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
YeAnbang
reviewed
Aug 4, 2025
| # [minibatch_size x num_of_generation] | ||
| loss_mask = torch.ones(action_mask.size(0), device=action_mask.device).bool() | ||
| # [minibatch_size x num_of_generation] | ||
| loss_mask = torch.ones(action_mask.size(0), device=action_mask.device).bool() | ||
|
|
There was a problem hiding this comment.
may be better to move the common calculations outside of the if statements for conciseness
YeAnbang
reviewed
Aug 4, 2025
| # [minibatch_size x num_generations] | ||
| advantages = ((reward - reward_mean)).unsqueeze(dim=-1) | ||
|
|
||
| advantages_mean = advantages.mean(dim=0) |
There was a problem hiding this comment.
Isn't the advantages_mean always 0 as advantage is already zero-centered in the previous step?
YeAnbang
reviewed
Aug 4, 2025
| advantages_std = advantages.std(dim=0) | ||
|
|
||
| advantages = (advantages - advantages_mean) / (advantages_std + 1e-4) | ||
|
|
There was a problem hiding this comment.
maybe consider double-checking the reinforce++ baseline advantage calculation. In reinforce ++, each sample's advantage is calculated by subtracting the mean reward of all generation in the global batch, not per prompt mean
YeAnbang
reviewed
Aug 4, 2025
| @@ -0,0 +1,2 @@ | |||
| 4.51.0: qwen2.5 + grpo, qwen3 + grpo, cannot: llama2, llama3.2 | |||
| 4.47.0: | |||
YeAnbang
reviewed
Aug 4, 2025
| @@ -227,13 +227,13 @@ | |||
| os.environ["TOKENIZERS_PARALLELISM"] = "false" # Disable tokenizers parallelism to avoid deadlock | |||
|
|
|||
| inference_model_config = dict(path=args.model) | |||
| train_model_config = dict(path=args.model, use_flash_attention_2=True, use_cache=False) | |||
| train_model_config = dict(path=args.model, use_flash_attention_2=False, use_cache=False) | |||
There was a problem hiding this comment.
why is flash attention not supported?
YeAnbang
reviewed
Aug 4, 2025
| generate_config = dict(top_k=args.top_k, top_p=args.top_p, temperature=args.temperature) | ||
|
|
||
| if args.backend == "transformers": | ||
| inference_model_config.update( | ||
| dict( | ||
| use_flash_attention_2=True, | ||
| use_flash_attention_2=False, |
YeAnbang
reviewed
Aug 4, 2025
There was a problem hiding this comment.
probably also consider force num_generation to 1 for reinforce++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6367
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise descriptionpip install pre-commit && pre-commit install🚨 Issue number
📝 What does this PR do?
Add more training models (LLaMA3, Qwen3) and RLHF algorithms (REINFORCE++, RLOO).
💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.